-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove animation #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove animation #910
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-remove-animation.primer.now.sh |
| import {version} from '../../../../../package.json' | ||
| import {ReactComponent as HeroIllustration} from '../../../hero-illustration.svg' | ||
|
|
||
| const HeroAnimation = loadable(() => import('../../../hero-animation'), {fallback: <HeroIllustration />}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we need to remove the loadable import from this file as well.
|
Should we also remove dependencies used for the animation like bodymovin and loadable? |
|
If we want to keep the animation but improve performance we could look into replacing the animations to only use It might not be possible to convert everything.. like the "drawing of the line", but moving things around, fade in/out should be fine. |
|
Fixes: #909