Skip to content

Conversation

@emplums
Copy link
Contributor

@emplums emplums commented Sep 24, 2019

Fixes: #909

@emplums emplums requested a review from shawnbot September 24, 2019 17:12
@vercel
Copy link

vercel bot commented Sep 24, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-remove-animation.primer.now.sh

import {version} from '../../../../../package.json'
import {ReactComponent as HeroIllustration} from '../../../hero-illustration.svg'

const HeroAnimation = loadable(() => import('../../../hero-animation'), {fallback: <HeroIllustration />})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need to remove the loadable import from this file as well.

@colebemis
Copy link
Contributor

Should we also remove dependencies used for the animation like bodymovin and loadable?

@simurai
Copy link
Contributor

simurai commented Apr 2, 2020

If we want to keep the animation but improve performance we could look into replacing the animations to only use opacity, transform and filter. These are the only properties that can be "hardware accelerated" and don't need reptainting for every frame. See https://www.sitepoint.com/introduction-to-hardware-acceleration-css-animations/.

It might not be possible to convert everything.. like the "drawing of the line", but moving things around, fade in/out should be fine.

Base automatically changed from master to main March 26, 2021 00:50
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2021

⚠️ No Changeset found

Latest commit: daa9c84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan merged commit 454124e into main May 26, 2021
@jonrohan jonrohan deleted the remove-animation branch May 26, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace animation with more performant SVG

6 participants